IGB handling of zero length checksumming?

IGB handling of zero length checksumming?

[David Miller]

If the IGB is given a "skb->ip_summed === CHECKSUM_PARTIAL" packet and
the data area past the TCP header is of zero length, will it do the
right thing?

I'm asking because I made a change recently in net-2.6 that causes TCP
packets with no data (ACKs, etc.) to start using CHECKSUM_PARTIAL.

And a user with IGB interfaces on a system running net-2.6 is getting
failures connecting to SSH and stuff like that and it is known that
this TCP commit of mine is the culprit.  See:

http://marc.info/?l=linux-netdev&m=127097744616962&w=2

I'm very likely to just revert this change regardless of what the
problem is, and try to sort this out in net-next-2.6, but it'd be nice
to know if IGB indeed has a problem in this area and that's the true
cause of the issue.

Thanks!

Re: IGB handling of zero length checksumming?

[David Miller]

From: David Miller <davem@davemloft.net>
Date: Sun, 11 Apr 2010 02:40:27 -0700 (PDT)

> 
> If the IGB is given a "skb->ip_summed === CHECKSUM_PARTIAL" packet and
> the data area past the TCP header is of zero length, will it do the
> right thing?

Hey guys you don't have to worry about this.

The problem turned out to be somewhere else. :-)