From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: yinghai@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: ssh server etc doesn't work anymore with net-2.6
Date: Sun, 11 Apr 2010 14:43:13 -0700 (PDT) [thread overview]
Message-ID: <20100411.144313.71127091.davem@davemloft.net> (raw)
In-Reply-To: <20100411120403.GA20565@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 11 Apr 2010 20:04:03 +0800
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>
>> After looking at the actual net-2.6 tree I see that it is actually
>> CHECKSUM_PARTIAL that caused this breakage.
>>
>> The fact that when this was first implemented we didn't use hw
>> checksums on dataless packets might not have been an oversight
>> after all.
>
> Looks like I was too quick to blame the hardware, the synack
> code can't handle CHECKSUM_PARTIAL so this is probably the real
> cause.
>
> I will send patches to fix this.
Thanks a lot for figuring this out.
I'll put my original patch (with fixed commit log message!)
and your fixes into net-next-2.6
next prev parent reply other threads:[~2010-04-11 21:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-11 9:17 ssh server etc doesn't work anymore with net-2.6 Yinghai Lu
2010-04-11 9:21 ` David Miller
2010-04-11 9:24 ` David Miller
2010-04-11 9:32 ` Yinghai Lu
2010-04-11 9:33 ` David Miller
2010-04-11 9:43 ` David Miller
2010-04-11 10:09 ` Herbert Xu
2010-04-11 12:04 ` Herbert Xu
2010-04-11 21:43 ` David Miller [this message]
2010-04-11 12:15 ` [PATCH 1/3] tcp: Handle CHECKSUM_PARTIAL for SYNACK packets for IPv4 Herbert Xu
2010-04-11 21:07 ` Yinghai
2010-04-11 22:00 ` David Miller
2010-04-11 12:15 ` [PATCH 2/3] tcp: Handle CHECKSUM_PARTIAL for SYNACK packets for IPv6 Herbert Xu
2010-04-11 12:15 ` [PATCH 3/3] inet: Remove unused send_check length argument Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100411.144313.71127091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).