From: David Miller <davem@davemloft.net>
To: hjk@linutronix.de
Cc: socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
kernel@pengutronix.de, 21cnbao@gmail.com, celston@katalix.com,
chripell@evolware.org, wg@grandegger.com, haas@ems-wuenche.com,
per.dalen@cnw.se, P.B.Cheblakov@inp.nsk.su,
oliver.hartkopp@volkswagen.de, anantgole@ti.com
Subject: Re: [PATCH] Fix some #includes in CAN drivers
Date: Tue, 13 Apr 2010 01:36:14 -0700 (PDT) [thread overview]
Message-ID: <20100413.013614.200995710.davem@davemloft.net> (raw)
In-Reply-To: <20100408192545.GD2004@bluebox.local>
From: "Hans J. Koch" <hjk@linutronix.de>
Date: Thu, 8 Apr 2010 21:25:45 +0200
> In the current implementation, CAN drivers need to #include <linux/can.h>
> _before_ they #include <linux/can/dev.h>, which is both ugly and
> unnecessary.
>
> Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the
> #include <linux/can.h> lines from drivers.
>
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
This doesn't apply cleanly to net-next-2.6, please respin your patch
and resubmit.
Thanks.
next prev parent reply other threads:[~2010-04-13 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 19:25 [PATCH] Fix some #includes in CAN drivers Hans J. Koch
2010-04-13 8:36 ` David Miller [this message]
[not found] ` <20100413.013614.200995710.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-04-13 9:51 ` Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413.013614.200995710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=21cnbao@gmail.com \
--cc=P.B.Cheblakov@inp.nsk.su \
--cc=anantgole@ti.com \
--cc=celston@katalix.com \
--cc=chripell@evolware.org \
--cc=haas@ems-wuenche.com \
--cc=hjk@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=per.dalen@cnw.se \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).