From: David Miller <davem@davemloft.net>
To: ffainelli@freebox.fr
Cc: netdev@vger.kernel.org, mbizon@freebox.fr
Subject: Re: [PATCH 2/2] bcm63xx_enet: do not overwrite ENET_CTL_REG value
Date: Tue, 13 Apr 2010 03:30:30 -0700 (PDT) [thread overview]
Message-ID: <20100413.033030.144455634.davem@davemloft.net> (raw)
In-Reply-To: <201004091304.52540.ffainelli@freebox.fr>
From: Florian Fainelli <ffainelli@freebox.fr>
Date: Fri, 9 Apr 2010 13:04:52 +0200
> bcm_enet_hw_preinit will correctly set values in ENET_CTL_REG for internal
> or external MII operations, however, bcm_enet_open will blindly overwrite the
> ENET_CTL_REG register value and thus we will loose any changes to it that
> were made in bcm_enet_hw_preinit, rendering external MII operations non-working.
>
> This would lead to the driver not being able to check for link availability on
> external PHY setups, and thus we would never get to sending packets because
> link was down from the driver side.
>
> This was completely un-noticed because all boards out there but BCM6338-based
> ones use internal phy on their enet0 interface.
>
> Signed-off-by: Florian Fainelli <ffainelli@freebox.fr>
Applied.
prev parent reply other threads:[~2010-04-13 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 11:04 [PATCH 2/2] bcm63xx_enet: do not overwrite ENET_CTL_REG value Florian Fainelli
2010-04-13 10:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413.033030.144455634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ffainelli@freebox.fr \
--cc=mbizon@freebox.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).