* [PATCH] dst: don't inline dst_ifdown
@ 2010-04-12 17:38 Stephen Hemminger
2010-04-13 10:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-04-12 17:38 UTC (permalink / raw)
To: David Miller; +Cc: netdev
The function dst_ifdown is called only two places but in a non-
performance critical code path, there is no reason to inline it.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/core/dst.c 2010-04-11 12:30:44.228996074 -0700
+++ b/net/core/dst.c 2010-04-11 12:32:15.488707752 -0700
@@ -285,8 +285,8 @@ EXPORT_SYMBOL(dst_release);
*
* Commented and originally written by Alexey.
*/
-static inline void dst_ifdown(struct dst_entry *dst, struct net_device *dev,
- int unregister)
+static void dst_ifdown(struct dst_entry *dst, struct net_device *dev,
+ int unregister)
{
if (dst->ops->ifdown)
dst->ops->ifdown(dst, dev, unregister);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dst: don't inline dst_ifdown
2010-04-12 17:38 [PATCH] dst: don't inline dst_ifdown Stephen Hemminger
@ 2010-04-13 10:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-13 10:34 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 12 Apr 2010 10:38:05 -0700
> The function dst_ifdown is called only two places but in a non-
> performance critical code path, there is no reason to inline it.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-13 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-12 17:38 [PATCH] dst: don't inline dst_ifdown Stephen Hemminger
2010-04-13 10:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).