From: "Hans J. Koch" <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: haas-zsNKPWJ8Piak0Ce0JJ2bFg@public.gmane.org,
celston-Bm0nJX+W7e9BDgjK7y7TUQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
per.dalen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org,
chripell-LERDrqjqfvZg9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH] Fix some #includes in CAN drivers
Date: Tue, 13 Apr 2010 11:51:26 +0200 [thread overview]
Message-ID: <20100413095125.GB2011@bluebox.local> (raw)
In-Reply-To: <20100413.013614.200995710.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Tue, Apr 13, 2010 at 01:36:14AM -0700, David Miller wrote:
> From: "Hans J. Koch" <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> Date: Thu, 8 Apr 2010 21:25:45 +0200
>
> > In the current implementation, CAN drivers need to #include <linux/can.h>
> > _before_ they #include <linux/can/dev.h>, which is both ugly and
> > unnecessary.
> >
> > Fix this by including <linux/can.h> in <linux/can/dev.h> and remove the
> > #include <linux/can.h> lines from drivers.
> >
> > Signed-off-by: Hans J. Koch <hjk-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
>
> This doesn't apply cleanly to net-next-2.6, please respin your patch
> and resubmit.
Ooops, sorry. Will resubmit immediately.
Thanks,
Hans
prev parent reply other threads:[~2010-04-13 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 19:25 [PATCH] Fix some #includes in CAN drivers Hans J. Koch
2010-04-13 8:36 ` David Miller
[not found] ` <20100413.013614.200995710.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-04-13 9:51 ` Hans J. Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413095125.GB2011@bluebox.local \
--to=hjk-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=celston-Bm0nJX+W7e9BDgjK7y7TUQ@public.gmane.org \
--cc=chripell-LERDrqjqfvZg9hUCZPvPmw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=haas-zsNKPWJ8Piak0Ce0JJ2bFg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org \
--cc=per.dalen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).