netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] CONFIG_SMP should be CONFIG_RPS
  2010-04-13 14:36 [PATCH] CONFIG_SMP should be CONFIG_RPS Changli Gao
@ 2010-04-13  6:59 ` Eric Dumazet
  2010-04-15  7:16   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2010-04-13  6:59 UTC (permalink / raw)
  To: Changli Gao; +Cc: David S. Miller, netdev, Tom Herbert

Le mardi 13 avril 2010 à 22:36 +0800, Changli Gao a écrit :
> CONFIG_SMP should be CONFIG_RPS
> 
> CONFIG_SMP should be CONFIG_RPS
> 
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> ----
>  include/linux/netdevice.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index d1a21b5..0efb36e 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1331,7 +1331,7 @@ struct softnet_data {
>  	struct sk_buff		*completion_queue;
>  
>  	/* Elements below can be accessed between CPUs for RPS */
> -#ifdef CONFIG_SMP
> +#ifdef CONFIG_RPS
>  	struct call_single_data	csd ____cacheline_aligned_in_smp;
>  #endif
>  	struct sk_buff_head	input_pkt_queue;

Thanks Changli, this is part of RFS patches :)



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] CONFIG_SMP should be CONFIG_RPS
@ 2010-04-13 14:36 Changli Gao
  2010-04-13  6:59 ` Eric Dumazet
  0 siblings, 1 reply; 3+ messages in thread
From: Changli Gao @ 2010-04-13 14:36 UTC (permalink / raw)
  To: David S. Miller; +Cc: Eric Dumazet, netdev, Tom Herbert, Changli Gao

CONFIG_SMP should be CONFIG_RPS

CONFIG_SMP should be CONFIG_RPS

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
 include/linux/netdevice.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index d1a21b5..0efb36e 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1331,7 +1331,7 @@ struct softnet_data {
 	struct sk_buff		*completion_queue;
 
 	/* Elements below can be accessed between CPUs for RPS */
-#ifdef CONFIG_SMP
+#ifdef CONFIG_RPS
 	struct call_single_data	csd ____cacheline_aligned_in_smp;
 #endif
 	struct sk_buff_head	input_pkt_queue;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] CONFIG_SMP should be CONFIG_RPS
  2010-04-13  6:59 ` Eric Dumazet
@ 2010-04-15  7:16   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-04-15  7:16 UTC (permalink / raw)
  To: eric.dumazet; +Cc: xiaosuo, netdev, therbert

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 13 Apr 2010 08:59:07 +0200

> Thanks Changli, this is part of RFS patches :)
> 

I'll apply this, Tom has to respin RFS for other reasons
already...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-15  7:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-13 14:36 [PATCH] CONFIG_SMP should be CONFIG_RPS Changli Gao
2010-04-13  6:59 ` Eric Dumazet
2010-04-15  7:16   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).