From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiaosuo@gmail.com, therbert@google.com, eparis@redhat.com,
netdev@vger.kernel.org
Subject: Re: BUG: using smp_processor_id() in preemptible [00000000] code: avahi-daemon: caller is netif_rx
Date: Thu, 15 Apr 2010 02:02:46 -0700 (PDT) [thread overview]
Message-ID: <20100415.020246.218622820.davem@davemloft.net> (raw)
In-Reply-To: <1271321358.16881.2240.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 15 Apr 2010 10:49:18 +0200
> Maybe we should add a new function after all...
>
> int netif_rx_any(struct sk_buff *skb)
> {
> if (in_interrupt())
> return netif_rx(skb);
>
> return netif_rx_ni(skb);
> }
Ok, thanks for the analysis.
Since we keep coming back to this issue why don't we simply
solve it forever? Let's make netif_rx() work in all contexts
and get rid of netif_rx_ni().
I think this is the thing to do because this whole netif_rx_ni()
vs. netif_rx() thing was meant to be an optimization of sorts (this
goes back to like 8+ years ago :-), and really I doubt it really
matters on that level any more.
What do you think?
next prev parent reply other threads:[~2010-04-15 9:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 19:20 BUG: using smp_processor_id() in preemptible [00000000] code: avahi-daemon: caller is netif_rx Eric Paris
2010-04-12 19:40 ` Eric Dumazet
2010-04-12 20:54 ` Tom Herbert
2010-04-13 7:14 ` Eric Dumazet
2010-04-15 7:14 ` David Miller
2010-04-15 7:30 ` Changli Gao
2010-04-15 7:37 ` David Miller
2010-04-15 7:47 ` Changli Gao
2010-04-15 7:57 ` David Miller
2010-04-15 8:27 ` Changli Gao
2010-04-15 8:33 ` David Miller
2010-04-15 8:58 ` Eric Dumazet
2010-04-15 8:49 ` Eric Dumazet
2010-04-15 9:02 ` David Miller [this message]
2010-04-15 10:29 ` Eric Dumazet
2010-04-15 13:16 ` Eric Dumazet
2010-04-15 19:07 ` Eric Dumazet
2010-04-15 19:13 ` [PATCH] ip: Fix ip_dev_loopback_xmit() Eric Dumazet
2010-04-15 21:26 ` David Miller
2010-04-16 0:03 ` Changli Gao
2010-04-16 0:15 ` David Miller
2010-04-16 0:19 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415.020246.218622820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).