From: David Miller <davem@davemloft.net>
To: khc@pm.waw.pl
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver.
Date: Fri, 16 Apr 2010 15:41:17 -0700 (PDT) [thread overview]
Message-ID: <20100416.154117.164075021.davem@davemloft.net> (raw)
In-Reply-To: <m3mxx5mv8v.fsf@intrepid.localdomain>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Thu, 15 Apr 2010 02:09:52 +0200
> tx_queue is used as a temporary queue when not allowed to queue skb
> directly to the hw device driver (which may sleep). Most paths flush
> it before returning, but ppp_start() currently cannot. Make sure we
> don't leave skbs pointing to a non-existent device.
>
> Thanks to Michael Barkowski for reporting this problem.
>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
Applied, thank you.
next prev parent reply other threads:[~2010-04-16 22:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 0:09 [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver Krzysztof Halasa
2010-04-16 22:41 ` David Miller [this message]
2010-04-22 19:17 ` Michael Barkowski
2010-04-22 21:43 ` David Miller
2010-04-22 21:55 ` Michael Barkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416.154117.164075021.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).