From: David Miller <davem@davemloft.net>
To: daniel.lezcano@free.fr
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] packet : remove init_net restriction
Date: Fri, 16 Apr 2010 15:41:26 -0700 (PDT) [thread overview]
Message-ID: <20100416.154126.152614206.davem@davemloft.net> (raw)
In-Reply-To: <1271322674-21726-1-git-send-email-daniel.lezcano@free.fr>
From: Daniel Lezcano <daniel.lezcano@free.fr>
Date: Thu, 15 Apr 2010 11:11:14 +0200
> The af_packet protocol is used by Perl to do ioctls as reported by
> Stephane Riviere:
>
> "Net::RawIP relies on SIOCGIFADDR et SIOCGIFHWADDR to get the IP and MAC
> addresses of the network interface."
>
> But in a new network namespace these ioctl fail because it is disabled for
> a namespace different from the init_net_ns.
>
> These two lines should not be there as af_inet and af_packet are
> namespace aware since a long time now. I suppose we forget to remove these
> lines because we sent the af_packet first, before af_inet was supported.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
> Reported-by: Stephane Riviere <stephane.riviere@regis-dgac.net>
Applied, thanks!
prev parent reply other threads:[~2010-04-16 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 9:11 [PATCH net-2.6] packet : remove init_net restriction Daniel Lezcano
2010-04-16 15:04 ` Daniel Lezcano
2010-04-16 20:23 ` David Miller
2010-04-16 22:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416.154126.152614206.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.lezcano@free.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).