From: Herbert Xu <herbert@gondor.apana.org.au>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>,
yinghai.lu@oracle.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org,
"yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki"
<yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
dccp@vger.kernel.org, linux-sctp@vger.kernel.org,
kleptog@svana.org, jchapman@katalix.com, mostrows@speakeasy.net,
acme@xconectiva.com.br
Subject: Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
Date: Fri, 16 Apr 2010 14:43:44 +0800 [thread overview]
Message-ID: <20100416064344.GA12412@gondor.apana.org.au> (raw)
In-Reply-To: <4BC7CAC1.4000803@cn.fujitsu.com>
On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
>
> Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.
> So, now we can't remove the && ... bit.
Huh? If they still call ip_queue_xmit with ipfragok then surely
the build will fail after your patch as it removes the ipfragok
argument?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2010-04-16 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BC70EF1.6080400@cn.fujitsu.com>
2010-04-15 22:33 ` [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df David Miller
[not found] ` <20100415151926.GA4813@gondor.apana.org.au>
2010-04-16 2:26 ` Shan Wei
2010-04-16 6:43 ` Herbert Xu [this message]
2010-04-16 6:49 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416064344.GA12412@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=acme@xconectiva.com.br \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=jchapman@katalix.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kleptog@svana.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-sctp@vger.kernel.org \
--cc=mostrows@speakeasy.net \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shanwei@cn.fujitsu.com \
--cc=yinghai.lu@oracle.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).