From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: vladz@broadcom.com, eilong@broadcom.com, netdev@vger.kernel.org,
dmitry@broadcom.com
Subject: Re: [PATCH 11/13] bnx2x: Forbid LRO on when XEN is enabled
Date: Sun, 18 Apr 2010 20:58:58 -0700 (PDT) [thread overview]
Message-ID: <20100418.205858.193699902.davem@davemloft.net> (raw)
In-Reply-To: <1271603485.3679.210.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sun, 18 Apr 2010 16:11:25 +0100
> On Sun, 2010-04-18 at 17:50 +0300, Vladislav Zolotarov wrote:
>> LRO cannot be used on virtualized environment, so it is best
>> to disable it on compile time in XEN kernel.
> [...]
>
> If you want to cripple your performance, I'm not going to stand in your
> way, but be aware that most distribution kernels now enable CONFIG_XEN.
There is also zero reason to do this.
When the XEN code or whatever setups up the bridge, LRO will be
disabled by the bridge code.
It automatically issues ethtool LRO disable commands to the devices
involved in the bridge configuration. And it has done this for
a _long_ time. The ipv4 routing code will do the same.
This change is bogus and likely based upon behavior in some ancient
distribution kernel that lacks the ethtool facilities.
I absolutely refuse to apply this.
next prev parent reply other threads:[~2010-04-19 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 14:50 [PATCH 11/13] bnx2x: Forbid LRO on when XEN is enabled Vladislav Zolotarov
2010-04-18 15:11 ` Ben Hutchings
2010-04-19 3:58 ` David Miller [this message]
2010-04-19 16:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100418.205858.193699902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).