From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: xiaosuo@gmail.com, eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] rps: send IPIs ASAP
Date: Mon, 19 Apr 2010 22:39:36 -0700 (PDT) [thread overview]
Message-ID: <20100419.223936.193719455.davem@davemloft.net> (raw)
In-Reply-To: <g2y65634d661004192215oc06d9c43xb2a7c7d946149cf5@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Mon, 19 Apr 2010 22:15:58 -0700
> Did you test this to see what the impact is in this regard?
Changli it would help immensely if you posted performance
test results along with your changes.
I can see quite obviously that this change will completely undo the
intentional batching of IPIs done by RPS. IPIs are expensive and we
should batch things as much as possible here.
next prev parent reply other threads:[~2010-04-20 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 4:08 [PATCH] rps: send IPIs ASAP Changli Gao
2010-04-20 5:15 ` Tom Herbert
2010-04-20 5:39 ` David Miller [this message]
2010-04-20 5:45 ` Eric Dumazet
2010-04-20 9:17 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419.223936.193719455.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).