From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] gianfar: Wait for both RX and TX to stop Date: Tue, 20 Apr 2010 18:06:46 -0700 (PDT) Message-ID: <20100420.180646.216759318.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: galak@kernel.crashing.org, afleming@freescale.com, netdev@vger.kernel.org To: timur.tabi@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58516 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754517Ab0DUBGl convert rfc822-to-8bit (ORCPT ); Tue, 20 Apr 2010 21:06:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: =46rom: Timur Tabi Date: Tue, 20 Apr 2010 10:01:48 -0500 > On Mon, Apr 19, 2010 at 11:43 PM, Kumar Gala wrote: >=20 >> spin_event_timeout doesn't make sense for this. =A0The patch is fine= =2E >=20 > Can you please elaborate on that? I don't understand why you think > that. spin_event_timeout() takes an expression and a timeout, and > loops over the expression calling cpu_relax(), just like this loop > does. Indeed it does, Kumar this request seems reasonable.