* [PATCH] cxgb3: fix linkup issue
@ 2010-04-20 1:32 Hiroshi Shimamoto
2010-04-21 2:06 ` David Miller
2010-04-21 19:12 ` Divy Le Ray
0 siblings, 2 replies; 5+ messages in thread
From: Hiroshi Shimamoto @ 2010-04-20 1:32 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel@vger.kernel.org
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
I encountered an issue that not to link up on cxgb3 fabric.
I bisected and found that this regression was introduced by
0f07c4ee8c800923ae7918c231532a9256233eed.
Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep().
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
drivers/net/cxgb3/ael1002.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb3/ael1002.c b/drivers/net/cxgb3/ael1002.c
index 5248f9e..35cd367 100644
--- a/drivers/net/cxgb3/ael1002.c
+++ b/drivers/net/cxgb3/ael1002.c
@@ -934,7 +934,7 @@ static struct cphy_ops xaui_direct_ops = {
int t3_xaui_direct_phy_prep(struct cphy *phy, struct adapter *adapter,
int phy_addr, const struct mdio_ops *mdio_ops)
{
- cphy_init(phy, adapter, MDIO_PRTAD_NONE, &xaui_direct_ops, mdio_ops,
+ cphy_init(phy, adapter, phy_addr, &xaui_direct_ops, mdio_ops,
SUPPORTED_10000baseT_Full | SUPPORTED_AUI | SUPPORTED_TP,
"10GBASE-CX4");
return 0;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb3: fix linkup issue
2010-04-20 1:32 [PATCH] cxgb3: fix linkup issue Hiroshi Shimamoto
@ 2010-04-21 2:06 ` David Miller
2010-04-21 19:12 ` Divy Le Ray
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2010-04-21 2:06 UTC (permalink / raw)
To: h-shimamoto; +Cc: netdev, linux-kernel, divy
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Date: Tue, 20 Apr 2010 10:32:20 +0900
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> I encountered an issue that not to link up on cxgb3 fabric.
> I bisected and found that this regression was introduced by
> 0f07c4ee8c800923ae7918c231532a9256233eed.
>
> Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep().
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
CXGB3 maintainers, please review.
> ---
> drivers/net/cxgb3/ael1002.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb3/ael1002.c b/drivers/net/cxgb3/ael1002.c
> index 5248f9e..35cd367 100644
> --- a/drivers/net/cxgb3/ael1002.c
> +++ b/drivers/net/cxgb3/ael1002.c
> @@ -934,7 +934,7 @@ static struct cphy_ops xaui_direct_ops = {
> int t3_xaui_direct_phy_prep(struct cphy *phy, struct adapter *adapter,
> int phy_addr, const struct mdio_ops *mdio_ops)
> {
> - cphy_init(phy, adapter, MDIO_PRTAD_NONE, &xaui_direct_ops, mdio_ops,
> + cphy_init(phy, adapter, phy_addr, &xaui_direct_ops, mdio_ops,
> SUPPORTED_10000baseT_Full | SUPPORTED_AUI | SUPPORTED_TP,
> "10GBASE-CX4");
> return 0;
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb3: fix linkup issue
2010-04-20 1:32 [PATCH] cxgb3: fix linkup issue Hiroshi Shimamoto
2010-04-21 2:06 ` David Miller
@ 2010-04-21 19:12 ` Divy Le Ray
2010-04-21 23:34 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Divy Le Ray @ 2010-04-21 19:12 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: netdev, linux-kernel@vger.kernel.org
Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> I encountered an issue that not to link up on cxgb3 fabric.
> I bisected and found that this regression was introduced by
> 0f07c4ee8c800923ae7918c231532a9256233eed.
>
> Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep().
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
Sorry for the review delay, I just came back from some time off.
Acked-by: Divy Le Ray <divy@chelsio.com>
> ---
> drivers/net/cxgb3/ael1002.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb3/ael1002.c b/drivers/net/cxgb3/ael1002.c
> index 5248f9e..35cd367 100644
> --- a/drivers/net/cxgb3/ael1002.c
> +++ b/drivers/net/cxgb3/ael1002.c
> @@ -934,7 +934,7 @@ static struct cphy_ops xaui_direct_ops = {
> int t3_xaui_direct_phy_prep(struct cphy *phy, struct adapter *adapter,
> int phy_addr, const struct mdio_ops *mdio_ops)
> {
> - cphy_init(phy, adapter, MDIO_PRTAD_NONE, &xaui_direct_ops, mdio_ops,
> + cphy_init(phy, adapter, phy_addr, &xaui_direct_ops, mdio_ops,
> SUPPORTED_10000baseT_Full | SUPPORTED_AUI | SUPPORTED_TP,
> "10GBASE-CX4");
> return 0;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb3: fix linkup issue
2010-04-21 19:12 ` Divy Le Ray
@ 2010-04-21 23:34 ` David Miller
2010-05-10 0:22 ` Hiroshi Shimamoto
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2010-04-21 23:34 UTC (permalink / raw)
To: divy; +Cc: h-shimamoto, netdev, linux-kernel
From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 21 Apr 2010 12:12:14 -0700
> Hiroshi Shimamoto wrote:
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> I encountered an issue that not to link up on cxgb3 fabric.
>> I bisected and found that this regression was introduced by
>> 0f07c4ee8c800923ae7918c231532a9256233eed.
>>
>> Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep().
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>
> Sorry for the review delay, I just came back from some time off.
> Acked-by: Divy Le Ray <divy@chelsio.com>
Applied to net-2.6, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxgb3: fix linkup issue
2010-04-21 23:34 ` David Miller
@ 2010-05-10 0:22 ` Hiroshi Shimamoto
0 siblings, 0 replies; 5+ messages in thread
From: Hiroshi Shimamoto @ 2010-05-10 0:22 UTC (permalink / raw)
To: David Miller; +Cc: divy, netdev, linux-kernel
David Miller wrote:
> From: Divy Le Ray <divy@chelsio.com>
> Date: Wed, 21 Apr 2010 12:12:14 -0700
>
>> Hiroshi Shimamoto wrote:
>>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>>
>>> I encountered an issue that not to link up on cxgb3 fabric.
>>> I bisected and found that this regression was introduced by
>>> 0f07c4ee8c800923ae7918c231532a9256233eed.
>>>
>>> Correct to pass phy_addr to cphy_init() at t3_xaui_direct_phy_prep().
>>>
>>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>>
>> Sorry for the review delay, I just came back from some time off.
>> Acked-by: Divy Le Ray <divy@chelsio.com>
>
> Applied to net-2.6, thanks.
>
I think this patch should be in -stable, right?
I can see this issue on Fedora12 and Ubuntu10.04.
thanks,
Hiroshi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-10 0:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-20 1:32 [PATCH] cxgb3: fix linkup issue Hiroshi Shimamoto
2010-04-21 2:06 ` David Miller
2010-04-21 19:12 ` Divy Le Ray
2010-04-21 23:34 ` David Miller
2010-05-10 0:22 ` Hiroshi Shimamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).