Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ramirose@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c.
Date: Tue, 20 Apr 2010 19:26:01 -0700 (PDT)	[thread overview]
Message-ID: <20100420.192601.109636833.davem@davemloft.net> (raw)
In-Reply-To: <l2geb3ff54b1004190250qfe606c28i80dab5f156128f4c@mail.gmail.com>

From: Rami Rosen <ramirose@gmail.com>
Date: Mon, 19 Apr 2010 12:50:19 +0300

> There is no need to export skb_under_panic() and skb_over_panic() in
> skbuff.c, since these methods are used only in
> skbuff.c ; this patch removes these two exports.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

If this is indeed the case, you should also mark these functions
'static' and remove the extern declarations of them from
include/linux/skbuff.h

Please make those changes and resubmit your patch (against
net-next-2.6 since that's where it belongs at this point).

Thanks.

      reply	other threads:[~2010-04-21  2:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19  9:50 [PATCH net-2.6] cleanup: remove two unnecessary exports in skbuff.c Rami Rosen
2010-04-21  2:26 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100420.192601.109636833.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=ramirose@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox