From: David Miller <davem@davemloft.net>
To: galak@kernel.crashing.org
Cc: timur.tabi@gmail.com, afleming@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH] gianfar: Wait for both RX and TX to stop
Date: Tue, 20 Apr 2010 22:36:59 -0700 (PDT) [thread overview]
Message-ID: <20100420.223659.236667659.davem@davemloft.net> (raw)
In-Reply-To: <A20F7457-20BC-493C-B800-3933D8FC4D5C@kernel.crashing.org>
From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, 20 Apr 2010 23:22:19 -0500
>
> On Apr 20, 2010, at 8:06 PM, David Miller wrote:
>
>> From: Timur Tabi <timur.tabi@gmail.com>
>> Date: Tue, 20 Apr 2010 10:01:48 -0500
>>
>>> On Mon, Apr 19, 2010 at 11:43 PM, Kumar Gala <galak@kernel.crashing.org> wrote:
>>>
>>>> spin_event_timeout doesn't make sense for this. The patch is fine.
>>>
>>> Can you please elaborate on that? I don't understand why you think
>>> that. spin_event_timeout() takes an expression and a timeout, and
>>> loops over the expression calling cpu_relax(), just like this loop
>>> does.
>>
>> Indeed it does, Kumar this request seems reasonable.
>
> Are we saying that cpu_relax() is useless and should be removed if we are spinning on a HW register?
Kumar, take a deep breath and a step back.
spin_event_timeout() does the cpu_relax() too, that's what Timur is
trying to tell you.
The code will be basically identical as far as I can tell.
next prev parent reply other threads:[~2010-04-21 5:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 23:13 [PATCH] gianfar: Wait for both RX and TX to stop Andy Fleming
2010-04-19 21:08 ` Timur Tabi
2010-04-20 4:43 ` Kumar Gala
2010-04-20 15:01 ` Timur Tabi
2010-04-20 15:59 ` Timur Tabi
2010-04-21 1:06 ` David Miller
2010-04-21 4:22 ` Kumar Gala
2010-04-21 5:36 ` David Miller [this message]
2010-04-21 12:17 ` Kumar Gala
2010-04-21 14:33 ` Timur Tabi
2010-04-21 19:13 ` Kumar Gala
2010-04-21 21:33 ` David Miller
2010-04-20 4:44 ` Kumar Gala
2010-04-20 8:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420.223659.236667659.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
--cc=timur.tabi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).