Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: fix outsegs stat for TSO segments
Date: Wed, 21 Apr 2010 22:28:27 -0700 (PDT)	[thread overview]
Message-ID: <20100421.222827.15606873.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.1.00.1004212214110.14731@pokey.mtv.corp.google.com>

From: Tom Herbert <therbert@google.com>
Date: Wed, 21 Apr 2010 22:17:24 -0700 (PDT)

>  	if (after(tcb->end_seq, tp->snd_nxt) || tcb->seq == tcb->end_seq)
> -		TCP_INC_STATS(sock_net(sk), TCP_MIB_OUTSEGS);
> +		TCP_ADD_STATS(sock_net(sk), TCP_MIB_OUTSEGS,
> +		    tcp_skb_pcount(skb));

Please follow proper coding style and make the new line
with the 'tcp_skb_pcount(skb)' argument line up with
the start of the macro arguments on the previous line.

      reply	other threads:[~2010-04-22  5:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  5:17 [PATCH] tcp: fix outsegs stat for TSO segments Tom Herbert
2010-04-22  5:28 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421.222827.15606873.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox