From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] rps: optimize rps_get_cpu() Date: Wed, 21 Apr 2010 22:40:14 -0700 (PDT) Message-ID: <20100421.224014.77255834.davem@davemloft.net> References: <1271772160-28177-1-git-send-email-xiaosuo@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: therbert@google.com, eric.dumazet@gmail.com, netdev@vger.kernel.org To: xiaosuo@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59019 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290Ab0DVFkK (ORCPT ); Thu, 22 Apr 2010 01:40:10 -0400 In-Reply-To: <1271772160-28177-1-git-send-email-xiaosuo@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Changli Gao Date: Tue, 20 Apr 2010 22:02:40 +0800 > use ihl in bytes to eliminate later multiplyings. I'll buy you a cookie if you can find a multiply generated by the compiler for "x * 4". It's going to use shifts and those are basically free. Please just change one thing at a time. It would have helped you here. I was willing to apply the port dereference part of your change, but not necessarily the 'ihl' changes. But because you've combined them, I have no choice but to reject everything.