From: David Miller <davem@davemloft.net>
To: brian.haley@hp.com
Cc: jolsa@redhat.com, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ipv6 bind to device issue
Date: Wed, 21 Apr 2010 22:50:15 -0700 (PDT) [thread overview]
Message-ID: <20100421.225015.137831360.davem@davemloft.net> (raw)
In-Reply-To: <4BCDEED3.7040901@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Tue, 20 Apr 2010 14:13:39 -0400
> Actually, looking at this again, we might want to swap the order
> here since fl->oif should be filled-in for most link-local and
> multicast requests calling this:
>
> if (fl->oif || rt6_need_strict(&fl->fl6_dst))
>
> Just a thought, but it potentially saves a call to determine
> the scope of the address.
Yes I think we should make this change.
Jiri please respin your patch with the argument order
reversed so that we can make the inexpensive check before
the expensive one.
Thanks.
next prev parent reply other threads:[~2010-04-22 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 12:46 [PATCH] net: ipv6 bind to device issue Jiri Olsa
2010-04-20 15:41 ` Brian Haley
2010-04-20 15:42 ` Jiri Olsa
2010-04-20 18:13 ` Brian Haley
2010-04-21 7:21 ` Jiri Olsa
2010-04-22 5:50 ` David Miller [this message]
2010-04-22 5:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421.225015.137831360.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=jolsa@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).