* [PATCH] ethernet: print protocol in host byte order
@ 2010-04-21 7:06 Johannes Berg
2010-04-22 5:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2010-04-21 7:06 UTC (permalink / raw)
To: netdev; +Cc: Eric Dumazet
Eric's recent patch added __force, but this
place would seem to require actually doing
a byte order conversion so the printk is
consistent across architectures.
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/ethernet/eth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 3584696..0c0d272 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -136,7 +136,7 @@ int eth_rebuild_header(struct sk_buff *skb)
default:
printk(KERN_DEBUG
"%s: unable to resolve type %X addresses.\n",
- dev->name, (__force int)eth->h_proto);
+ dev->name, ntohs(eth->h_proto));
memcpy(eth->h_source, dev->dev_addr, ETH_ALEN);
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethernet: print protocol in host byte order
2010-04-21 7:06 [PATCH] ethernet: print protocol in host byte order Johannes Berg
@ 2010-04-22 5:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-22 5:57 UTC (permalink / raw)
To: johannes; +Cc: netdev, eric.dumazet
From: Johannes Berg <johannes@sipsolutions.net>
Date: Wed, 21 Apr 2010 09:06:07 +0200
> Eric's recent patch added __force, but this
> place would seem to require actually doing
> a byte order conversion so the printk is
> consistent across architectures.
>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Applied to net-next-2.6, thanks a lot Johannes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-22 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 7:06 [PATCH] ethernet: print protocol in host byte order Johannes Berg
2010-04-22 5:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).