* cxgb4: Use ntohs() on __be16 value instead of htons()
@ 2010-04-21 18:09 Roland Dreier
2010-04-21 19:17 ` Dimitris Michailidis
0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2010-04-21 18:09 UTC (permalink / raw)
To: Dimitris Michailidis, David S. Miller; +Cc: netdev
Use the correct direction of byte-swapping function to fix a mistake
shown by sparse endianness checking -- c.fl0id is __be16.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
drivers/net/cxgb4/sge.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb4/sge.c b/drivers/net/cxgb4/sge.c
index 14adc58..70bf2b2 100644
--- a/drivers/net/cxgb4/sge.c
+++ b/drivers/net/cxgb4/sge.c
@@ -2047,7 +2047,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,
adap->sge.ingr_map[iq->cntxt_id] = iq;
if (fl) {
- fl->cntxt_id = htons(c.fl0id);
+ fl->cntxt_id = ntohs(c.fl0id);
fl->avail = fl->pend_cred = 0;
fl->pidx = fl->cidx = 0;
fl->alloc_failed = fl->large_alloc_failed = fl->starving = 0;
--
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: cxgb4: Use ntohs() on __be16 value instead of htons()
2010-04-21 18:09 cxgb4: Use ntohs() on __be16 value instead of htons() Roland Dreier
@ 2010-04-21 19:17 ` Dimitris Michailidis
2010-04-22 6:00 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dimitris Michailidis @ 2010-04-21 19:17 UTC (permalink / raw)
To: Roland Dreier; +Cc: David S. Miller, netdev
On 04/21/2010 11:09 AM, Roland Dreier wrote:
> Use the correct direction of byte-swapping function to fix a mistake
> shown by sparse endianness checking -- c.fl0id is __be16.
>
> Signed-off-by: Roland Dreier<rolandd@cisco.com>
Yes, thanks.
Acked-by: Dimitris Michailidis <dm@chelsio.com>
> ---
> drivers/net/cxgb4/sge.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/cxgb4/sge.c b/drivers/net/cxgb4/sge.c
> index 14adc58..70bf2b2 100644
> --- a/drivers/net/cxgb4/sge.c
> +++ b/drivers/net/cxgb4/sge.c
> @@ -2047,7 +2047,7 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,
> adap->sge.ingr_map[iq->cntxt_id] = iq;
>
> if (fl) {
> - fl->cntxt_id = htons(c.fl0id);
> + fl->cntxt_id = ntohs(c.fl0id);
> fl->avail = fl->pend_cred = 0;
> fl->pidx = fl->cidx = 0;
> fl->alloc_failed = fl->large_alloc_failed = fl->starving = 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: cxgb4: Use ntohs() on __be16 value instead of htons()
2010-04-21 19:17 ` Dimitris Michailidis
@ 2010-04-22 6:00 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-04-22 6:00 UTC (permalink / raw)
To: dm; +Cc: rdreier, netdev
From: Dimitris Michailidis <dm@chelsio.com>
Date: Wed, 21 Apr 2010 12:17:43 -0700
> On 04/21/2010 11:09 AM, Roland Dreier wrote:
>> Use the correct direction of byte-swapping function to fix a mistake
>> shown by sparse endianness checking -- c.fl0id is __be16.
>>
>> Signed-off-by: Roland Dreier<rolandd@cisco.com>
>
> Yes, thanks.
>
> Acked-by: Dimitris Michailidis <dm@chelsio.com>
Applied to net-next-2.6
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-22 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-21 18:09 cxgb4: Use ntohs() on __be16 value instead of htons() Roland Dreier
2010-04-21 19:17 ` Dimitris Michailidis
2010-04-22 6:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox