From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: hadi@cyberus.ca, therbert@google.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v5] net: batch skb dequeueing from softnet input_pkt_queue
Date: Thu, 22 Apr 2010 02:43:36 -0700 (PDT) [thread overview]
Message-ID: <20100422.024336.119875321.davem@davemloft.net> (raw)
In-Reply-To: <1271927357-2973-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Thu, 22 Apr 2010 17:09:17 +0800
> + unsigned int input_pkt_queue_len;
> + struct sk_buff *input_pkt_queue_head;
> + struct sk_buff **input_pkt_queue_tailp;
> +
Please do not ignore Stephen Hemminger's feedback.
We already have enough odd SKB queue implementations, we
do not need yet another one in a core location. This makes
it harder and harder to eventually convert sk_buff to use
"struct list_head".
Instead, use "struct sk_buff_head" and the lockless accessors
(__skb_insert, etc.) and initializer (__skb_queue_head_init).
next prev parent reply other threads:[~2010-04-22 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:09 [PATCH v5] net: batch skb dequeueing from softnet input_pkt_queue Changli Gao
2010-04-22 9:43 ` David Miller [this message]
2010-04-22 12:27 ` Changli Gao
2010-04-22 14:24 ` Eric Dumazet
2010-04-22 11:37 ` Eric Dumazet
2010-04-22 12:17 ` jamal
2010-04-22 13:06 ` Changli Gao
2010-04-22 14:33 ` Eric Dumazet
2010-04-22 14:54 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422.024336.119875321.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).