From: David Miller <davem@davemloft.net>
To: inaky@linux.intel.com
Cc: error27@gmail.com, netdev@vger.kernel.org,
andre.goddard@gmail.com, kernel-janitors@vger.kernel.org,
wimax@linuxwimax.org, linux-wimax@intel.com
Subject: Re: [patch] wimax: wimax_msg_alloc() returns ERR_PTR not null
Date: Thu, 22 Apr 2010 15:56:30 -0700 (PDT) [thread overview]
Message-ID: <20100422.155630.10951183.davem@davemloft.net> (raw)
In-Reply-To: <1271973596.2867.3.camel@localhost.localdomain>
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Date: Thu, 22 Apr 2010 14:59:56 -0700
> On Thu, 2010-04-22 at 11:46 +0200, Dan Carpenter wrote:
>> wimax_msg_alloc() returns an ERR_PTR and not null. I changed it to test
>> for ERR_PTR instead of null. I also added a check in front of the
>> kfree() because kfree() can handle null but not ERR_PTR.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Good catch thank you!
>
> Will merge ASAP in preparation for the next push
There was another wimax fix from Dan, subject:
[patch] wimax: checking ERR_PTR vs null
make sure you integrate that one too.
prev parent reply other threads:[~2010-04-22 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:46 [patch] wimax: wimax_msg_alloc() returns ERR_PTR not null Dan Carpenter
2010-04-22 21:59 ` Inaky Perez-Gonzalez
2010-04-22 22:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422.155630.10951183.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andre.goddard@gmail.com \
--cc=error27@gmail.com \
--cc=inaky@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).