From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: andy.grover@oracle.com, rds-devel@oss.oracle.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rdma: potential ERR_PTR dereference
Date: Thu, 22 Apr 2010 15:57:54 -0700 (PDT) [thread overview]
Message-ID: <20100422.155754.233400086.davem@davemloft.net> (raw)
In-Reply-To: <20100422095527.GQ29647@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 22 Apr 2010 11:55:27 +0200
> In the original code, the "goto out" calls "rdma_destroy_id(cm_id);"
> That isn't needed here and would cause problems because "cm_id" is an
> ERR_PTR. The new code just returns directly.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
prev parent reply other threads:[~2010-04-22 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:55 [patch] rdma: potential ERR_PTR dereference Dan Carpenter
2010-04-22 17:28 ` Andy Grover
2010-04-22 22:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422.155754.233400086.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.grover@oracle.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).