From: David Miller <davem@davemloft.net>
To: alan@linux.intel.com
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH] e100: Fix the TX workqueue race
Date: Fri, 23 Apr 2010 16:31:27 -0700 (PDT) [thread overview]
Message-ID: <20100423.163127.62645049.davem@davemloft.net> (raw)
In-Reply-To: <20100423143356.7092.45260.stgit@localhost.localdomain>
From: Alan Cox <alan@linux.intel.com>
Date: Fri, 23 Apr 2010 15:34:43 +0100
> I'd assumed someone would have picked up on this and fixed it using rtnl_lock
> as was suggested but it seems to have fallen through the cracks ?
>
> Anyway this is I assume what was meant ?
I hope this doesn't deadlock with linkwatch, as that's generally
a problem we hit with trying to take RTNL from workqueues in
the networking.
Linkwatch takes the RTNL lock, and then can make calls into the driver
in it's main work loop.
But since you don't hold any driver locks here (you can't as if we did
we couldn't take the RTNL lock here at all) so it should be OK.
I'll apply this to net-2.6, thanks Alan.
next prev parent reply other threads:[~2010-04-23 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 14:34 [PATCH] e100: Fix the TX workqueue race Alan Cox
2010-04-23 16:20 ` Jeff Garzik
2010-04-23 23:31 ` David Miller [this message]
2010-04-23 23:35 ` David Miller
2010-04-24 10:36 ` Alan Cox
2010-04-25 3:00 ` David Miller
2010-04-24 11:11 ` Alan Cox
2010-04-25 2:58 ` David Miller
2010-04-25 4:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423.163127.62645049.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@linux.intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).