From: Stephen Hemminger <shemminger@vyatta.com>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, alexander.h.duyck@intel.com,
peter.p.waskiewicz.jr@intel.com, john.ronciak@intel.com
Subject: Re: [PATCH] e100: expose broadcast_disabled as a module option
Date: Fri, 23 Apr 2010 15:02:07 -0700 [thread overview]
Message-ID: <20100423150207.7969c9f6@nehalam> (raw)
In-Reply-To: <r2ob43bf5491004231403o64f8b88bsa9543d9910648d97@mail.gmail.com>
On Fri, 23 Apr 2010 23:03:59 +0200
Erwan Velu <erwanaliasr1@gmail.com> wrote:
> I first tried "ifconfig -broadcast" without any success, so I forced
> the driver to unset IFF_BROADCAST, the interface didn't showed anymore
> the BROADCAST option with ifconfig. But I didn't noticed any reduction
> in the amount of context/switches on my host.
>
> I found the broadcast_disabled far more efficient when considering the
> cpu impact.
The point is that the driver can look at IFF_BROADCAST rather than having
module parameter. Module parameters are device driver specific and should
be avoid as much as possible in favor of general mechanism. This is a repeated
problem where users and vendors make special hooks that only work with their
driver, which makes life hard for other users and distribution providers.
next prev parent reply other threads:[~2010-04-23 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <l2nb43bf5491004231314i13503c67yeccfc54bc1cae850@mail.gmail.com>
2010-04-23 20:22 ` [PATCH] e100: expose broadcast_disabled as a module option Jeff Kirsher
2010-04-23 20:58 ` Stephen Hemminger
2010-04-23 21:03 ` Erwan Velu
2010-04-23 22:02 ` Stephen Hemminger [this message]
2010-04-26 8:49 ` Erwan Velu
2010-04-26 14:45 ` Erwan Velu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423150207.7969c9f6@nehalam \
--to=shemminger@vyatta.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=erwanaliasr1@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).