netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] r8169: more broken register writes workaround
@ 2010-04-26 21:42 François Romieu
  2010-04-26 22:37 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: François Romieu @ 2010-04-26 21:42 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, Al Viro

78f1cd02457252e1ffbc6caa44a17424a45286b8 ("fix broken register writes")
does not work for Al Viro's r8169 (XID 18000000).

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 drivers/net/r8169.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 2b54389..4748c21 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2826,8 +2826,13 @@ static void rtl_rar_set(struct rtl8169_private *tp, u8 *addr)
 	spin_lock_irq(&tp->lock);
 
 	RTL_W8(Cfg9346, Cfg9346_Unlock);
+
 	RTL_W32(MAC4, high);
+	RTL_R32(MAC4);
+
 	RTL_W32(MAC0, low);
+	RTL_R32(MAC0);
+
 	RTL_W8(Cfg9346, Cfg9346_Lock);
 
 	spin_unlock_irq(&tp->lock);
-- 
1.6.6.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] r8169: more broken register writes workaround
  2010-04-26 21:42 [PATCH 2/2] r8169: more broken register writes workaround François Romieu
@ 2010-04-26 22:37 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-26 22:37 UTC (permalink / raw)
  To: romieu; +Cc: netdev, viro

From: François Romieu <romieu@fr.zoreil.com>
Date: Mon, 26 Apr 2010 23:42:58 +0200

> 78f1cd02457252e1ffbc6caa44a17424a45286b8 ("fix broken register writes")
> does not work for Al Viro's r8169 (XID 18000000).
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-26 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-26 21:42 [PATCH 2/2] r8169: more broken register writes workaround François Romieu
2010-04-26 22:37 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).