From: Oliver Neukum <oneukum@suse.de>
To: Torgny Johansson <torgny.johansson@ericsson.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH torvalds-2.6] cdc_ether: fix autosuspend for mbm devices
Date: Mon, 26 Apr 2010 12:30:21 +0200 [thread overview]
Message-ID: <201004261230.21713.oneukum@suse.de> (raw)
In-Reply-To: <201004261214.13836.torgny.johansson@ericsson.com>
Am Montag, 26. April 2010 12:14:13 schrieb Torgny Johansson:
> Hi!
>
> In 2.6.33 it seems autosuspend is broken for mbm devices.
It is hardly broken. It simply wasn't implemented.
> Autosuspend works until you bring the wwan interface up, then the device does not enter autosuspend anymore.
>
> The following patch fixes the problem by setting the .manage_power field in the mbm_info struct
> to the same as in the cdc_info struct (cdc_manager_power).
>
> I am unsure exactly what that does and why autosuspend doesn't work without it.
> Can you guys comment on that? Is this fix the correct approach?
The patch is correct. If you use another struct driver_info it is a different
driver as far as usbnet is concerned. A driver needs to give some
minimal support for autosuspend. mbm didn't do so.
> Also, if you like this patch, is it possible to get it included in a minor release of 2.6.33 (e.g. 2.6.33.3) as a bugfix?
Up to David.
Regards
Oliver
next prev parent reply other threads:[~2010-04-26 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 10:14 [PATCH torvalds-2.6] cdc_ether: fix autosuspend for mbm devices Torgny Johansson
2010-04-26 10:30 ` Oliver Neukum [this message]
2010-04-28 0:07 ` David Miller
2010-04-28 7:07 ` Torgny Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004261230.21713.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=netdev@vger.kernel.org \
--cc=torgny.johansson@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).