From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: error27@gmail.com, sri@us.ibm.com, yjwei@cn.fujitsu.com,
cdischino@sonusnet.com, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] sctp: cleanup: remove duplicate assignment
Date: Tue, 27 Apr 2010 09:58:23 -0700 (PDT) [thread overview]
Message-ID: <20100427.095823.98890165.davem@davemloft.net> (raw)
In-Reply-To: <4BD6F582.9030804@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Tue, 27 Apr 2010 10:32:34 -0400
>
>
> Dan Carpenter wrote:
>> This assignment isn't needed because we did it earlier already.
>>
>> Also another reason to delete the assignment is because it triggers a
>> Smatch warning about checking for NULL pointers after a dereference.
>>
>> Reported-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Thanks. I'll take this one.
And when will I get this from you? :-)
next prev parent reply other threads:[~2010-04-27 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 11:59 [patch] sctp: cleanup: remove unneeded null check Dan Carpenter
2010-04-23 14:28 ` Vlad Yasevich
2010-04-24 17:19 ` [patch v2] sctp: cleanup: remove duplicate assignment Dan Carpenter
2010-04-27 14:32 ` Vlad Yasevich
2010-04-27 16:58 ` David Miller [this message]
2010-04-27 17:32 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.095823.98890165.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cdischino@sonusnet.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
--cc=vladislav.yasevich@hp.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).