From: David Miller <davem@davemloft.net>
To: agimenez@sysvalve.es
Cc: error27@gmail.com, diego@giagio.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] ipheth: potential null dereferences on error path
Date: Tue, 27 Apr 2010 14:33:13 -0700 (PDT) [thread overview]
Message-ID: <20100427.143313.135530432.davem@davemloft.net> (raw)
In-Reply-To: <20100427210003.GA13873@bart.evergreen.loc>
From: L. Alberto Giménez <agimenez@sysvalve.es>
Date: Tue, 27 Apr 2010 23:00:03 +0200
> On Tue, Apr 27, 2010 at 11:20:12AM +0200, Dan Carpenter wrote:
>> The calls to usb_free_buffer() dereference rx_urb and tx_urb in the
>> parameter list but those could be NULL.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Seems good to me (should I ack it or any other kind of singoff?).
If you give it an "Acked-by: ..." that would be nice.
next prev parent reply other threads:[~2010-04-27 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 9:20 [patch] ipheth: potential null dereferences on error path Dan Carpenter
2010-04-27 21:00 ` L. Alberto Giménez
2010-04-27 21:33 ` David Miller [this message]
2010-04-27 21:43 ` L. Alberto Giménez
2010-04-27 21:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.143313.135530432.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=agimenez@sysvalve.es \
--cc=diego@giagio.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).