From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, jfeeney@redhat.com
Subject: Re: [PATCH 2/3] bnx2: Prevent "scheduling while atomic" warning with cnic, bonding and vlan.
Date: Tue, 27 Apr 2010 14:38:34 -0700 (PDT) [thread overview]
Message-ID: <20100427.143834.35819121.davem@davemloft.net> (raw)
In-Reply-To: <1272403691-2934-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Tue, 27 Apr 2010 14:28:10 -0700
> The bonding driver calls ndo_vlan_rx_register() while holding bond->lock.
> The bnx2 driver calls bnx2_netif_stop() to stop the rx handling while
> changing the vlgrp. The call also stops the cnic driver which sleeps
> while the bond->lock is held and cause the warning.
>
> This code path only needs to stop the NAPI rx handling while we are
> changing the vlgrp. Since no reset is going to occur, there is no need
> to stop cnic in this case. By adding a parameter to bnx2_netif_stop()
> to skip stopping cnic, we can avoid the warning.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied to net-2.6
next prev parent reply other threads:[~2010-04-27 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 21:28 [PATCH 1/3] bnx2: Fix lost MSI-X problem on 5709 NICs Michael Chan
2010-04-27 21:28 ` [PATCH 2/3] bnx2: Prevent "scheduling while atomic" warning with cnic, bonding and vlan Michael Chan
2010-04-27 21:28 ` [PATCH 3/3] bnx2: Update version to 2.0.9 Michael Chan
2010-04-27 21:38 ` David Miller
2010-04-27 21:38 ` David Miller [this message]
2010-04-27 21:38 ` [PATCH 1/3] bnx2: Fix lost MSI-X problem on 5709 NICs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.143834.35819121.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jfeeney@redhat.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).