From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: dm@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] cxgb4: set skb->rxhash
Date: Tue, 27 Apr 2010 15:44:38 -0700 (PDT) [thread overview]
Message-ID: <20100427.154438.133411714.davem@davemloft.net> (raw)
In-Reply-To: <20100427153656.7bcaba83@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 27 Apr 2010 15:36:56 -0700
>> +static int set_flags(struct net_device *dev, u32 flags)
>> +{
>> + if (flags & ~ETH_FLAG_RXHASH)
>> + return -EOPNOTSUPP;
>> +
>> + if (flags & ETH_FLAG_RXHASH)
>> + dev->features |= NETIF_F_RXHASH;
>> + else
>> + dev->features &= ~NETIF_F_RXHASH;
>> + return 0;
>> +}
>
> You need to check for and reject other values NTUPLE and LRO
He does, it's the first he does in the function.
next prev parent reply other threads:[~2010-04-27 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 22:20 [PATCH net-next] cxgb4: set skb->rxhash Dimitris Michailidis
2010-04-27 22:36 ` Stephen Hemminger
2010-04-27 22:39 ` Dimitris Michailidis
2010-04-27 22:44 ` David Miller [this message]
2010-04-27 22:43 ` Eric Dumazet
2010-04-27 22:45 ` David Miller
2010-04-27 22:43 ` David Miller
2010-04-27 22:46 ` Dimitris Michailidis
2010-04-27 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.154438.133411714.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).