From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dm@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] cxgb4: set skb->rxhash
Date: Tue, 27 Apr 2010 15:45:32 -0700 (PDT) [thread overview]
Message-ID: <20100427.154532.128588325.davem@davemloft.net> (raw)
In-Reply-To: <1272408192.2343.32.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 28 Apr 2010 00:43:12 +0200
> Le mardi 27 avril 2010 à 15:20 -0700, Dimitris Michailidis a écrit :
>> Implement the ->set_flags ethtool method to control NETIF_F_RXHASH and
>> set skb->rxhash to the HW calculated hash accordingly.
>>
>> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
>
>> skb_record_rx_queue(skb, rxq->rspq.idx);
>> + if (rxq->rspq.netdev->features & NETIF_F_RXHASH)
>> + skb->rxhash = ntohl(pkt->rsshdr.hash_val);
>>
>
> Its probably minor, but hash_val being a semi random 32bits value, you
> can avoid the ntohl() conversion, using a (__force u32) cast ...
Agreed.
next prev parent reply other threads:[~2010-04-27 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 22:20 [PATCH net-next] cxgb4: set skb->rxhash Dimitris Michailidis
2010-04-27 22:36 ` Stephen Hemminger
2010-04-27 22:39 ` Dimitris Michailidis
2010-04-27 22:44 ` David Miller
2010-04-27 22:43 ` Eric Dumazet
2010-04-27 22:45 ` David Miller [this message]
2010-04-27 22:43 ` David Miller
2010-04-27 22:46 ` Dimitris Michailidis
2010-04-27 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.154532.128588325.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).