From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] cxgb4: set skb->rxhash
Date: Tue, 27 Apr 2010 15:47:41 -0700 (PDT) [thread overview]
Message-ID: <20100427.154741.172557759.davem@davemloft.net> (raw)
In-Reply-To: <4BD76955.1030104@chelsio.com>
From: Dimitris Michailidis <dm@chelsio.com>
Date: Tue, 27 Apr 2010 15:46:45 -0700
> David Miller wrote:
>> From: Dimitris Michailidis <dm@chelsio.com>
>> Date: Tue, 27 Apr 2010 15:20:25 -0700
>>
>>> Implement the ->set_flags ethtool method to control NETIF_F_RXHASH and
>>> set skb->rxhash to the HW calculated hash accordingly.
>>>
>>> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
>> Does the CXGB4 hash the ports for non-TCP packets?
>> If not, you will need to check the packet type (preferrably using
>> RX descriptor information rather than actually parsing the packet)
>> and only record the ->rxhash for TCP packets.
>>
>
> It does, optionally. Someday I need to implement ->set_rxnfc to
> expose the few available options but it's on by default.
Great, if you could respin this patch and ditch the ntohl() as Eric
suggested I'll apply it.
Thanks!
prev parent reply other threads:[~2010-04-27 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 22:20 [PATCH net-next] cxgb4: set skb->rxhash Dimitris Michailidis
2010-04-27 22:36 ` Stephen Hemminger
2010-04-27 22:39 ` Dimitris Michailidis
2010-04-27 22:44 ` David Miller
2010-04-27 22:43 ` Eric Dumazet
2010-04-27 22:45 ` David Miller
2010-04-27 22:43 ` David Miller
2010-04-27 22:46 ` Dimitris Michailidis
2010-04-27 22:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.154741.172557759.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).