From: David Miller <davem@davemloft.net>
To: danms@us.ibm.com
Cc: containers@lists.osdl.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] [RFC] Add sock_create_kern_net()
Date: Tue, 27 Apr 2010 17:18:44 -0700 (PDT) [thread overview]
Message-ID: <20100427.171844.77354120.davem@davemloft.net> (raw)
In-Reply-To: <1272034539-19899-3-git-send-email-danms@us.ibm.com>
From: Dan Smith <danms@us.ibm.com>
Date: Fri, 23 Apr 2010 07:55:37 -0700
> This helper allows kernel routines to create a socket in a given netns,
> instead of forcing it to the initial or current one.
>
> I know this seems like it's violating the netns boundary. The intended
> use (as in the following patches) is specifically when talking to RTNETLINK
> in another netns for the purposes of creating or examining resources there.
> It is expected that this will be used for that sort of transient socket
> creation only. In other words:
If you can create netlink sockets in a remote NS you can also make
changes there, and the whole point is to disallow changes.
So maybe you won't be making changes, but others will think about
using this and doing so.
At a high level, I think this is a really bad idea, so I won't be
applying this, sorry.
next prev parent reply other threads:[~2010-04-28 0:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 14:55 Checkpoint and Restart of INET routing information Dan Smith
[not found] ` <1272034539-19899-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-04-23 14:55 ` [PATCH 1/4] Fix acquiring socket lock before reading RTNETLINK response Dan Smith
[not found] ` <1272034539-19899-2-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-04-23 15:24 ` Dan Smith
2010-04-23 14:55 ` [PATCH 2/4] [RFC] Add sock_create_kern_net() Dan Smith
2010-04-28 0:18 ` David Miller [this message]
2010-04-28 2:18 ` Vlad Yasevich
2010-04-28 15:06 ` Dan Smith
2010-04-28 11:44 ` jamal
2010-04-28 13:38 ` Dan Smith
2010-04-23 14:55 ` [PATCH 3/4] C/R: Make rtnl_open() and rtnl_do() take and pass a netns pointer Dan Smith
2010-04-23 14:55 ` [PATCH 4/4] C/R: inet4 and inet6 unicast routes Dan Smith
2010-04-28 14:24 ` Checkpoint and Restart of INET routing information Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427.171844.77354120.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=containers@lists.osdl.org \
--cc=danms@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).