netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: epasheva@sierrawireless.com
Cc: dbrownell@users.sourceforge.net, rfiler@sierrawireless.com,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5] net/usb: add sierra_net.c driver
Date: Tue, 27 Apr 2010 18:11:49 -0700 (PDT)	[thread overview]
Message-ID: <20100427.181149.179278301.davem@davemloft.net> (raw)
In-Reply-To: <20100427.180732.121248582.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 27 Apr 2010 18:07:32 -0700 (PDT)

> From: Elina Pasheva <epasheva@sierrawireless.com>
> Date: Tue, 27 Apr 2010 17:48:31 -0700
> 
>> Subject: [PATCH v5] net/usb: add sierra_net.c driver
> 
> Applied, although I had to manually remove the stray extra
> newline at the end of drivers/net/usb/sierra_net.c which GIT
> complains about when the patch is applied.

I also had to fix up the following warning during the build:

drivers/net/usb/sierra_net.c: In function ‘sierra_net_parse_lsi’:
drivers/net/usb/sierra_net.c:365: warning: format ‘%u’ expects type ‘unsigned int’, but argument 7 has type ‘long unsigned int’

"size_t" objects must use the "z" format specifier, so "%zu" is what
should have been used here.

  reply	other threads:[~2010-04-28  1:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28  0:48 [PATCH v5] net/usb: add sierra_net.c driver Elina Pasheva
2010-04-28  1:07 ` David Miller
2010-04-28  1:11   ` David Miller [this message]
     [not found]     ` <20100427.181149.179278301.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-04-28  1:19       ` Elina Pasheva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427.181149.179278301.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=epasheva@sierrawireless.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rfiler@sierrawireless.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).