* [net-next-2.6 PATCH 1/2] igb: double increment nr_frags
@ 2010-04-27 11:01 Jeff Kirsher
2010-04-27 11:01 ` [net-next-2.6 PATCH 2/2] igbvf: " Jeff Kirsher
2010-04-27 19:55 ` [net-next-2.6 PATCH 1/2] igb: " David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Kirsher @ 2010-04-27 11:01 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Koki Sanagi, Jeff Kirsher
From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
There is no need to increment nr_frags because skb_fill_page_desc increments
it.
Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/igb/igb_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index c19b1e0..a14303a 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -5248,7 +5248,7 @@ static bool igb_clean_rx_irq_adv(struct igb_q_vector *q_vector,
PAGE_SIZE / 2, PCI_DMA_FROMDEVICE);
buffer_info->page_dma = 0;
- skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+ skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
buffer_info->page,
buffer_info->page_offset,
length);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [net-next-2.6 PATCH 2/2] igbvf: double increment nr_frags
2010-04-27 11:01 [net-next-2.6 PATCH 1/2] igb: double increment nr_frags Jeff Kirsher
@ 2010-04-27 11:01 ` Jeff Kirsher
2010-04-27 19:55 ` David Miller
2010-04-27 19:55 ` [net-next-2.6 PATCH 1/2] igb: " David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Kirsher @ 2010-04-27 11:01 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Koki Sanagi, Jeff Kirsher
From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
There is no need to increment nr_frags because skb_fill_page_desc increments
it.
Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/igbvf/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c
index cc23090..9ac3f94 100644
--- a/drivers/net/igbvf/netdev.c
+++ b/drivers/net/igbvf/netdev.c
@@ -289,7 +289,7 @@ static bool igbvf_clean_rx_irq(struct igbvf_adapter *adapter,
PCI_DMA_FROMDEVICE);
buffer_info->page_dma = 0;
- skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
+ skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
buffer_info->page,
buffer_info->page_offset,
length);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] igbvf: double increment nr_frags
2010-04-27 11:01 ` [net-next-2.6 PATCH 2/2] igbvf: " Jeff Kirsher
@ 2010-04-27 19:55 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-04-27 19:55 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sanagi.koki
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 27 Apr 2010 04:01:39 -0700
> From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
>
> There is no need to increment nr_frags because skb_fill_page_desc increments
> it.
>
> Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-next-2.6 PATCH 1/2] igb: double increment nr_frags
2010-04-27 11:01 [net-next-2.6 PATCH 1/2] igb: double increment nr_frags Jeff Kirsher
2010-04-27 11:01 ` [net-next-2.6 PATCH 2/2] igbvf: " Jeff Kirsher
@ 2010-04-27 19:55 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-04-27 19:55 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sanagi.koki
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 27 Apr 2010 04:01:19 -0700
> From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
>
> There is no need to increment nr_frags because skb_fill_page_desc increments
> it.
>
> Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-27 19:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 11:01 [net-next-2.6 PATCH 1/2] igb: double increment nr_frags Jeff Kirsher
2010-04-27 11:01 ` [net-next-2.6 PATCH 2/2] igbvf: " Jeff Kirsher
2010-04-27 19:55 ` David Miller
2010-04-27 19:55 ` [net-next-2.6 PATCH 1/2] igb: " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).