From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 06/17] sfc: Extend the legacy interrupt workarounds
Date: Wed, 28 Apr 2010 12:45:47 -0700 (PDT) [thread overview]
Message-ID: <20100428.124547.48527963.davem@davemloft.net> (raw)
In-Reply-To: <1272482907.2549.22.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 28 Apr 2010 20:28:27 +0100
> From: Steve Hodgson <shodgson@solarflare.com>
>
> Siena has two problems with legacy interrupts:
> 1. There is no synchronisation between the ISR read completion,
> and the interrupt deassert message.
> 2. A downstream read at the "wrong" moment can return 0, and
> suppress generating the next interrupt.
>
> Falcon should suffer from both of these, and it appears it does.
> Enable EFX_WORKAROUND_15783 on Falcon as well.
>
> Also, when we see queues == 0, ensure we always schedule or rearm
> every event queue.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
next prev parent reply other threads:[~2010-04-28 19:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 19:25 [PATCH 01/17] sfc: Ignore parity errors in the other port's SRAM Ben Hutchings
2010-04-28 19:27 ` [PATCH 02/17] sfc: Consistently report short MCDI responses as EIO Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:27 ` [PATCH 03/17] sfc: Handle serious errors in exactly one interrupt handler Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:27 ` [PATCH 04/17] sfc: Stop masking out XGMII faults over reconfigures Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:28 ` [PATCH 05/17] sfc: Reconfigure the XAUI serdes after an EM reset Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:28 ` [PATCH 06/17] sfc: Extend the legacy interrupt workarounds Ben Hutchings
2010-04-28 19:45 ` David Miller [this message]
2010-04-28 19:28 ` [PATCH 07/17] sfc: Log specific message for failure of NVRAM self-test Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:28 ` [PATCH 08/17] sfc: Read MEM_STAT for SRM_PERR as well as MEM_PERR errors Ben Hutchings
2010-04-28 19:45 ` David Miller
2010-04-28 19:29 ` [PATCH 09/17] sfc: Enable IPv6 RSS using random key for Toeplitz hash Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:29 ` [PATCH 10/17] sfc: Update MCDI protocol definitions Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:29 ` [PATCH 11/17] sfc: Set PERIODIC_NOEVENT flag for MC_CMD_MAC_STATS Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:29 ` [PATCH 12/17] sfc: Break NAPI processing after one ring-full of TX completions Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:29 ` [PATCH 13/17] sfc: Add necessary parentheses to macro definitions in net_driver.h Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:30 ` [PATCH 14/17] sfc: Clean up efx_nic::irq_zero_count Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:30 ` [PATCH 15/17] sfc: Add Siena PHY BIST and cable diagnostic support Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:30 ` [PATCH 16/17] sfc: Test only the first pair of TX queues Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:30 ` [PATCH 17/17] sfc: Create multiple " Ben Hutchings
2010-04-28 19:46 ` David Miller
2010-04-28 19:45 ` [PATCH 01/17] sfc: Ignore parity errors in the other port's SRAM David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428.124547.48527963.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).