From: David Miller <davem@davemloft.net>
To: bruce.w.allan@intel.com
Cc: anton@samba.org, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, mjg@redhat.com
Subject: Re: [net-2.6 PATCH] e1000e: enable/disable ASPM L0s and L1 and ERT according to hardware errata
Date: Thu, 29 Apr 2010 12:04:16 -0700 (PDT) [thread overview]
Message-ID: <20100429.120416.184828647.davem@davemloft.net> (raw)
In-Reply-To: <8DD2590731AB5D4C9DBF71A877482A9062274501@orsmsx509.amr.corp.intel.com>
From: "Allan, Bruce W" <bruce.w.allan@intel.com>
Date: Thu, 29 Apr 2010 10:19:56 -0700
> Your patch is probably the correct thing to do but I'm not all that
> familiar with the ppc64 architecture. Would you please provide the
> output of 'lspci -t' and 'lspci -vvv -xxx'.
You're not guarenteed for there to be a pci_dev backing the top-level
host controller, at the very least. Some platforms don't even implement
the PCI config space for the host controller, whilst on others access
to them is protected by the hypervisor.
So you can't go poking around the PCI host controller registers
unconditionally.
The same OOPS probably would happen on Sparc64 in some configurations
too. Although all of my PCI-E slots do have PCI-E express switch port
nodes, so maybe it wouldn't trigger here.
next prev parent reply other threads:[~2010-04-30 16:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 13:33 [net-2.6 PATCH] e1000e: enable/disable ASPM L0s and L1 and ERT according to hardware errata Jeff Kirsher
2010-04-27 13:43 ` Matthew Garrett
2010-04-27 17:18 ` David Miller
2010-04-29 7:46 ` Anton Blanchard
2010-04-29 17:19 ` Allan, Bruce W
2010-04-29 19:04 ` David Miller [this message]
2010-04-30 19:27 ` Allan, Bruce W
2010-04-30 19:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429.120416.184828647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=bruce.w.allan@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mjg@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).