Re: sierra_net default m

Re: sierra_net default m

[Elina Pasheva]

On Fri, 2010-04-30 at 10:28 -0700, Jens Axboe wrote:
> Hi,
> 
> Can we please not add new drivers that default to y/m? Any new driver
> should default to 'n'.
> 
Hi,
OK. Makes sense, so that the kernel does not build the driver if the
configuration option is not explicitly set.


David, would you like me to issue a patch for that for sierra_net
driver?
Is this the general rule one should follow when adding a new driver?

Thanks,
Elina

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: sierra_net default m

[David Miller]

From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
Date: Fri, 30 Apr 2010 11:45:50 -0700

> OK. Makes sense, so that the kernel does not build the driver if the
> configuration option is not explicitly set.

All non-core drivers should default to "n".

The default controls what the user is suggested to choose when they
run the configuration without an explicit setting in their existing
config.

They should never be told to turn on a driver by default for an
odd-ball piece of hardware.

Even the IDE and ATA disk layers don't default to anything explicitly.

Just remove the default tag altogether.  I see that a bunch of other USB
networking drivers have all sorts of default tags, I wish you didn't
follow their lead. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html