From: David Miller <davem@davemloft.net>
To: oneukum@suse.de
Cc: jonas.sjoquist@ericsson.com, netdev@vger.kernel.org
Subject: Re: [PATCH/RFC Resubmission] cdc_ether: Identify MBM devices by GUID in MDLM descriptor
Date: Fri, 30 Apr 2010 16:28:02 -0700 (PDT) [thread overview]
Message-ID: <20100430.162802.236246160.davem@davemloft.net> (raw)
In-Reply-To: <201004281051.44212.oneukum@suse.de>
From: Oliver Neukum <oneukum@suse.de>
Date: Wed, 28 Apr 2010 10:51:44 +0200
> Am Mittwoch, 28. April 2010 02:09:59 schrieb David Miller:
>> From: Jonas Sjoquist <jonas.sjoquist@ericsson.com>
>> Date: Fri, 23 Apr 2010 13:07:45 +0200
>>
>> > From: Jonas Sjöquist <jonas.sjoquist@ericsson.com>
>> >
>> > This patch removes vid/pid for Ericsson MBM devices from the whitelist set of
>> > devices. The MBM devices are instead identified by GUID.
>> >
>> > In order for cdc_ether to handle these devices the GUID in the MDLM descriptor
>> > is tested. All MBM devices currently handled by cdc_ether as well as future
>> > CDC Ethernet MBM devices can be identified by the GUID.
>> >
>> > This is the same solution used in Carl Nordbeck's mbm driver,
>> > http://kerneltrap.org/mailarchive/linux-usb/2008/11/17/4141384/thread
>> >
>> > I post this as RFC to get feedback on however cdc_ether is the correct place to
>> > do the binding, or if it should be done in a separate driver, e.g. zaurus.
>> >
>> > Signed-off-by: Jonas Sjöquist <jonas.sjoquist@ericsson.com>
>>
>> Can someone knowledgable with the cdc_ether driver review this change?
>
> The patch looks good.
Applied to net-next-2.6, thanks everyone.
prev parent reply other threads:[~2010-04-30 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 11:07 [PATCH/RFC Resubmission] cdc_ether: Identify MBM devices by GUID in MDLM descriptor Jonas Sjoquist
2010-04-28 0:09 ` David Miller
2010-04-28 8:51 ` Oliver Neukum
2010-04-30 23:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430.162802.236246160.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jonas.sjoquist@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).