From: David Miller <davem@davemloft.net>
To: ben@simtec.co.uk
Cc: netdev@vger.kernel.org, tristram.ha@micrel.com, support@tincantools.com
Subject: Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem
Date: Sun, 02 May 2010 22:38:52 -0700 (PDT) [thread overview]
Message-ID: <20100502.223852.219748077.davem@davemloft.net> (raw)
In-Reply-To: <20100429231739.509103394@fluff.org.uk>
From: Ben Dooks <ben@simtec.co.uk>
Date: Fri, 30 Apr 2010 00:16:22 +0100
> From: Tristram Ha <Tristram.Ha@micrel.com>
>
> This fixes a transmit problem of the ks8851 snl network driver.
>
> Under heavy TCP traffic the device will stop transmitting. Turning off
> the transmit interrupt avoids this issue. A new workqueue was
> implemented to replace the functionality of the transmit interrupt processing.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@micrel.com>
Please, try to fix this properly. Unless you have a known chip errata
with the TX interrupt that cannot be worked around reasonably, which
would need to be detailed and explained completely in the commit log
message, you should try to figure out what the real problem is.
Otherwise just tossing everything to a workqueue looks like a hack, at
best.
I suspect you have some kind of race between IRQ processing and the
->ndo_start_xmit() handler, so you end up missing a queue wakeup.
Either that or you end up misprogramming the hardware due to the race.
There is no way I'm applying this as-is.
next prev parent reply other threads:[~2010-05-03 5:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 23:16 [patch 00/13] Micrel KSZ8851 updates and fixes Ben Dooks
2010-04-29 23:16 ` [patch 01/13] KS8851: Fix ks8851 snl transmit problem Ben Dooks
2010-05-03 5:38 ` David Miller [this message]
2010-05-03 19:06 ` Ha, Tristram
2010-05-03 20:03 ` David Miller
2010-05-03 21:11 ` Ha, Tristram
2010-05-03 21:13 ` David Miller
2010-05-03 20:04 ` David Miller
2010-04-29 23:16 ` [patch 02/13] KSZ8851-SNL: Fix receive interrupt problem Ben Dooks
2010-04-29 23:16 ` [patch 03/13] eeprom_93cx6: Add data direction control Ben Dooks
2010-04-30 11:12 ` Jean Delvare
2010-04-29 23:16 ` [patch 04/13] eeprom_93cx6: Add write support Ben Dooks
2010-04-29 23:16 ` [patch 05/13] KSZ8851-SNL: Add support for EEPROM MAC address Ben Dooks
2010-04-29 23:16 ` [patch 06/13] KSZ8851-SNL: Fix MAC address change problem Ben Dooks
2010-04-29 23:16 ` [patch 07/13] KSZ8851-SNL: Add ethtool support for EEPROM Ben Dooks
2010-04-29 23:16 ` [patch 08/13] KSZ8851-SNL: Fix EEPROM access problem Ben Dooks
2010-04-29 23:16 ` [patch 09/13] KSZ8851-SNL: Add debugfs export for driver state Ben Dooks
2010-04-29 23:16 ` [patch 10/13] KS8851: ks8851_mll.c: Use the ks8851.h header for device register defines Ben Dooks
2010-04-29 23:16 ` [patch 11/13] KS8851: Update ks8851.h header from ks8851_mll.c Ben Dooks
2010-04-29 23:16 ` [patch 12/13] KS8851: Use the ks8851.h header to hold union ks8851_tx_hdr Ben Dooks
2010-04-29 23:16 ` [patch 13/13] KSZ8851-SNL: Add platform data to specific IRQ trigger type Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502.223852.219748077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@simtec.co.uk \
--cc=netdev@vger.kernel.org \
--cc=support@tincantools.com \
--cc=tristram.ha@micrel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).