From: David Miller <davem@davemloft.net>
To: simon@fire.lp0.eu
Cc: netdev@vger.kernel.org, paulus@samba.org, linux-ppp@vger.kernel.org
Subject: Re: [PATCH 1/2] ppp_generic: pull 2 bytes so that PPP_PROTO(skb) is valid
Date: Mon, 03 May 2010 12:49:02 -0700 (PDT) [thread overview]
Message-ID: <20100503.124902.51283117.davem@davemloft.net> (raw)
In-Reply-To: <e85216b167313bb2bd46f5990ed468f5b67a1ad8@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid>
From: "Simon Arlott" <simon@fire.lp0.eu>
Date: Mon, 3 May 2010 12:50:04 +0100
> Updated patch attached.
Two things:
1) Please don't post patches as binary attachments, it doesn't get
queued up properly into patchwork if you post it that way.
2) Always make a fresh email posting for new versions of your patch
when possible, as this way what to include in the commit log
message is clear and always applies to the patch posted rather
than bits and pieces of quoted material from previous postings
that may or may not apply to the current version of the patch.
So please repost this, and your new 2/2 patch, as clean new submissions.
Thanks.
prev parent reply other threads:[~2010-05-03 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 18:41 [PATCH 1/2] ppp_generic: pull 2 bytes so that PPP_PROTO(skb) is valid Simon Arlott
2010-04-30 18:41 ` [PATCH 2/2] ppp_generic: linearise skbs before passing them to pppd Simon Arlott
2010-05-03 6:27 ` David Miller
2010-05-03 16:51 ` [PATCH 2/2] ppp_generic: handle non-linear skbs when " Simon Arlott
2010-05-03 6:25 ` [PATCH 1/2] ppp_generic: pull 2 bytes so that PPP_PROTO(skb) is valid David Miller
2010-05-03 11:50 ` Simon Arlott
2010-05-03 19:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503.124902.51283117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).