From: David Miller <davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: ben@simtec.co.uk, netdev@vger.kernel.org, support@tincantools.com
Subject: Re: [patch 01/13] KS8851: Fix ks8851 snl transmit problem
Date: Mon, 03 May 2010 14:13:53 -0700 (PDT) [thread overview]
Message-ID: <20100503.141353.32722085.davem@davemloft.net> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D6DE671@MORGANITE.micrel.com>
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Mon, 3 May 2010 14:11:41 -0700
> I thought the transmit check workqueue reschedules itself when the
> buffer available is still not enough, and this is the part you objected.
If it reschedules itself, it runs immediately. That will just hog a cpu
endlessly until the TX packets start to be transmitted by the chip. That's
just as bad a polling in a loop.
You need to use an hrtimer or similar.
next prev parent reply other threads:[~2010-05-03 21:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 23:16 [patch 00/13] Micrel KSZ8851 updates and fixes Ben Dooks
2010-04-29 23:16 ` [patch 01/13] KS8851: Fix ks8851 snl transmit problem Ben Dooks
2010-05-03 5:38 ` David Miller
2010-05-03 19:06 ` Ha, Tristram
2010-05-03 20:03 ` David Miller
2010-05-03 21:11 ` Ha, Tristram
2010-05-03 21:13 ` David Miller [this message]
2010-05-03 20:04 ` David Miller
2010-04-29 23:16 ` [patch 02/13] KSZ8851-SNL: Fix receive interrupt problem Ben Dooks
2010-04-29 23:16 ` [patch 03/13] eeprom_93cx6: Add data direction control Ben Dooks
2010-04-30 11:12 ` Jean Delvare
2010-04-29 23:16 ` [patch 04/13] eeprom_93cx6: Add write support Ben Dooks
2010-04-29 23:16 ` [patch 05/13] KSZ8851-SNL: Add support for EEPROM MAC address Ben Dooks
2010-04-29 23:16 ` [patch 06/13] KSZ8851-SNL: Fix MAC address change problem Ben Dooks
2010-04-29 23:16 ` [patch 07/13] KSZ8851-SNL: Add ethtool support for EEPROM Ben Dooks
2010-04-29 23:16 ` [patch 08/13] KSZ8851-SNL: Fix EEPROM access problem Ben Dooks
2010-04-29 23:16 ` [patch 09/13] KSZ8851-SNL: Add debugfs export for driver state Ben Dooks
2010-04-29 23:16 ` [patch 10/13] KS8851: ks8851_mll.c: Use the ks8851.h header for device register defines Ben Dooks
2010-04-29 23:16 ` [patch 11/13] KS8851: Update ks8851.h header from ks8851_mll.c Ben Dooks
2010-04-29 23:16 ` [patch 12/13] KS8851: Use the ks8851.h header to hold union ks8851_tx_hdr Ben Dooks
2010-04-29 23:16 ` [patch 13/13] KSZ8851-SNL: Add platform data to specific IRQ trigger type Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503.141353.32722085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@Micrel.Com \
--cc=ben@simtec.co.uk \
--cc=netdev@vger.kernel.org \
--cc=support@tincantools.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).