From: David Miller <davem@davemloft.net>
To: jacmet@sunsite.dk
Cc: netdev@vger.kernel.org, michael.planes@free.fr, stable@kernel.org
Subject: Re: [PATCH] dm9601: fix phy/eeprom write routine
Date: Mon, 03 May 2010 15:27:00 -0700 (PDT) [thread overview]
Message-ID: <20100503.152700.11978044.davem@davemloft.net> (raw)
In-Reply-To: <1272916886-8841-1-git-send-email-jacmet@sunsite.dk>
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: Mon, 3 May 2010 22:01:26 +0200
> Use correct bit positions in DM_SHARED_CTRL register for writes.
>
> Michael Planes recently encountered a 'KY-RS9600 USB-LAN converter', which
> came with a driver CD containing a Linux driver. This driver turns out to
> be a copy of dm9601.c with symbols renamed and my copyright stripped.
> That aside, it did contain 1 functional change in dm_write_shared_word(),
> and after checking the datasheet the original value was indeed wrong
> (read versus write bits).
>
> On Michaels HW, this change bumps receive speed from ~30KB/s to ~900KB/s.
> On other devices the difference is less spectacular, but still significant
> (~30%).
>
> Reported-by: Michael Planes <michael.planes@free.fr>
> CC: stable@kernel.org
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
Applied, thanks!
prev parent reply other threads:[~2010-05-03 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 20:01 [PATCH] dm9601: fix phy/eeprom write routine Peter Korsgaard
2010-05-03 22:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503.152700.11978044.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jacmet@sunsite.dk \
--cc=michael.planes@free.fr \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).