From: David Miller <davem@davemloft.net>
To: sebastian@breakpoint.cc
Cc: afleming@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net/gianfar: drop recycled skbs on MTU change
Date: Mon, 03 May 2010 15:29:37 -0700 (PDT) [thread overview]
Message-ID: <20100503.152937.209596510.davem@davemloft.net> (raw)
In-Reply-To: <20100503151745.GA17997@Chamillionaire.breakpoint.cc>
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Mon, 3 May 2010 17:17:45 +0200
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> The size for skb which is added to the recycled list is using the
> current descriptor size which is current MTU. gfar_new_skb() is also
> using this size. So after changing or alteast increasing the MTU all
> recycled skbs should be dropped.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> I'm not 100% sure but it looks like it is wrong.
It looks right to me, can I get an ACK from gianfar developers?
next prev parent reply other threads:[~2010-05-03 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 15:17 [PATCH] net/gianfar: drop recycled skbs on MTU change Sebastian Andrzej Siewior
2010-05-03 22:29 ` David Miller [this message]
2010-05-04 15:29 ` Andy Fleming
2010-05-05 7:57 ` David Miller
2010-05-05 8:30 ` [PATCH v2] " Sebastian Andrzej Siewior
2010-05-05 15:18 ` Andy Fleming
2010-05-06 7:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503.152937.209596510.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).