From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ethernet: add sanity check before memory dereferencing
Date: Mon, 03 May 2010 23:11:56 -0700 (PDT) [thread overview]
Message-ID: <20100503.231156.69972880.davem@davemloft.net> (raw)
In-Reply-To: <1272944028-23410-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Tue, 4 May 2010 11:33:48 +0800
> add sanity check before memory dereferencing
>
> Some callers of eth_type_trans() only can assure the length of the packets
> passed to it is not less than ETH_HLEN. We'd better check the packets length
> before dereferencing skb->data.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
We can deference skb->data for at least 16 bytes or so past the end
of the valid packet data area however we want.
It might give garbage values, but it will not cause a fault or any
kind.
We want to remove checks here, not add new ones Changli.
prev parent reply other threads:[~2010-05-04 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 3:33 [PATCH] ethernet: add sanity check before memory dereferencing Changli Gao
2010-05-04 6:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503.231156.69972880.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).