From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: arnd@arndb.de, sri@us.ibm.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dlstevens@us.ibm.com
Subject: Re: [PATCH] macvtap: add ioctl to modify vnet header size
Date: Mon, 3 May 2010 10:55:11 +0300 [thread overview]
Message-ID: <20100503075511.GA8298@redhat.com> (raw)
In-Reply-To: <20100502.233439.77341308.davem@davemloft.net>
On Sun, May 02, 2010 at 11:34:39PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Sun, 02 May 2010 23:32:32 -0700 (PDT)
>
> > From: Arnd Bergmann <arnd@arndb.de>
> > Date: Thu, 29 Apr 2010 16:40:57 +0200
> >
> >> On Thursday 29 April 2010, Michael S. Tsirkin wrote:
> >>> This adds TUNSETVNETHDRSZ/TUNGETVNETHDRSZ support
> >>> to macvtap.
> >>
> >> Looks good, thanks Michael!
> >>
> >>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >>
> >> Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Applied to net-next-2.6, thanks.
>
> Nevermind, reverted:
>
> drivers/net/macvtap.c: In function 'macvtap_ioctl':
> drivers/net/macvtap.c:679:7: error: 'TUNGETVNETHDRSZ' undeclared (first use in this function)
> drivers/net/macvtap.c:679:7: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/macvtap.c:685:7: error: 'TUNSETVNETHDRSZ' undeclared (first use in this function)
>
> What tree is this supposed to build under? Certinaly not net-2.6
> or net-next-2.6
The reason is it needs to be applied on top of the patch that adds the
same header to tun that you acked. I put this in patch description:
> I plan to merge both patches through vhost tree together
> with mergeable buffer support. Comments?
In other words, this will be included in a pull request that I
intend to send out shortly.
--
MST
next prev parent reply other threads:[~2010-05-03 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 13:51 [PATCH] macvtap: add ioctl to modify vnet header size Michael S. Tsirkin
2010-04-29 14:40 ` Arnd Bergmann
2010-05-03 6:32 ` David Miller
2010-05-03 6:34 ` David Miller
2010-05-03 7:55 ` Michael S. Tsirkin [this message]
2010-05-03 8:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503075511.GA8298@redhat.com \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).