From: David Miller <davem@davemloft.net>
To: ddaney@caviumnetworks.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/6] netdev: octeon_mgmt: Use proper MAC addresses.
Date: Thu, 06 May 2010 00:18:43 -0700 (PDT) [thread overview]
Message-ID: <20100506.001843.229750901.davem@davemloft.net> (raw)
In-Reply-To: <1273100593-11043-2-git-send-email-ddaney@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 5 May 2010 16:03:08 -0700
> The original implementation incorrectly uses netdev->dev_addrs.
>
> Use netdev->uc instead. Also use netdev_for_each_uc_addr to iterate
> over the addresses. Fix comment.
>
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Applied.
next prev parent reply other threads:[~2010-05-06 7:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 23:03 [PATCH 0/6] netdev: octeon_mgmt: A few fixes for 2.6.35 David Daney
2010-05-05 23:03 ` [PATCH 1/6] netdev: octeon_mgmt: Use proper MAC addresses David Daney
2010-05-06 7:18 ` David Miller [this message]
2010-05-05 23:03 ` [PATCH 2/6] netdev: octeon_mgmt: Fix race condition freeing TX buffers David Daney
2010-05-06 7:18 ` David Miller
2010-05-05 23:03 ` [PATCH 3/6] netdev: octeon_mgmt: Fix race manipulating irq bits David Daney
2010-05-06 7:18 ` David Miller
2010-05-05 23:03 ` [PATCH 4/6] netdev: octeon_mgmt: Free TX skbufs in a timely manner David Daney
2010-05-06 7:19 ` David Miller
2010-05-05 23:03 ` [PATCH 5/6] netdev: octeon_mgmt: Try not to drop TX packets when stopping the queue David Daney
2010-05-06 7:19 ` David Miller
2010-05-05 23:03 ` [PATCH 6/6] netdev: octeon_mgmt: Remove some gratuitous blank lines David Daney
2010-05-06 7:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506.001843.229750901.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).